-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Issues pattern to a block template #988
Merged
GP-Dan-Tovbein
merged 3 commits into
main
from
PLANET-6942_convert-issues-pattern-to-block-template
Jan 16, 2023
Merged
Convert Issues pattern to a block template #988
GP-Dan-Tovbein
merged 3 commits into
main
from
PLANET-6942_convert-issues-pattern-to-block-template
Jan 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Dec 26, 2022
/unhold 64129a46-37a1-40af-9f5c-08b8f84050e5
Test instance is ready 🚀🌑 rhea | admin | blocks report | CircleCI | composer-local.json ⌚ 2023.01.16 16:42:03 |
7819605
to
fb845c7
Compare
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Dec 27, 2022
/unhold d2c65d23-a5aa-4d90-afeb-318d8b183d0e
GP-Dan-Tovbein
commented
Dec 27, 2022
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Dec 27, 2022
/unhold ff182318-6aba-4df3-8850-d1c5c1244609
mleray
reviewed
Jan 3, 2023
mleray
reviewed
Jan 3, 2023
- Also improve styles
fb845c7
to
fb16576
Compare
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Jan 13, 2023
/unhold 01ad417e-089d-4dce-bf56-868001cccc71
fb16576
to
4bab8ea
Compare
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Jan 13, 2023
/unhold 0233d7db-4f9b-4f35-80ed-3ce0cfcca16f
4bab8ea
to
e3e7563
Compare
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Jan 13, 2023
/unhold 92d57fed-5732-46b4-8638-aad22820c362
- New class for square images - Force to use square images when the square class is added
e3e7563
to
5ba2ac6
Compare
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Jan 13, 2023
/unhold 791777c4-f325-44ee-b23e-7a909342c91a
mleray
reviewed
Jan 16, 2023
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Jan 16, 2023
/unhold 87dacfdc-8423-4cb2-8a7e-cd5a63958a26
mleray
reviewed
Jan 16, 2023
mleray
reviewed
Jan 16, 2023
mleray
reviewed
Jan 16, 2023
73f8702
to
3c7360f
Compare
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Jan 16, 2023
/unhold cf14a77b-5b83-4fb7-b447-bd629e09b26c
- Font size family from px to rem, among other things
3c7360f
to
1c49630
Compare
planet-4
added a commit
to greenpeace/planet4-test-rhea
that referenced
this pull request
Jan 16, 2023
/unhold 3c034f42-b1d6-440e-9445-ca343d879523
mleray
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local, looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: PLANET-6942
Description
core/media-text
tocore/image
which works better with media sizes (width
,height
). Thecore/media-text
works with%
and it's difficult to follow exactly the UI.Demo page